MODUAD-199 - pubsub permission changes. #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurleenkaurbp
requested review from
Vignesh-kalyanasundaram,
julianladisch,
TarasSpashchenko and
kapil-epam
pom.xml
Outdated
There was a problem hiding this comment.
We either
- need a new validator version that allows "audit.pub-sub-handlers.log-record-event.post" to be defined in mod-pubsub.
- or, if we don't want to wait for the new version, need to disable the execution of this old version of the validator.
julianladisch
approved these changes
Nov 7, 2024
|
gurleenkaurbp
added a commit
that referenced
this pull request
Nov 19, 2024
* pubsub permission changes. * pubsub permission changes. * Changes related to audit.pub-sub-handlers.log-record-event.post * pubsub permission changes. * pubsub permission changes. --------- Co-authored-by: Taras_Spashchenko <[email protected]>
gurleenkaurbp
added a commit
that referenced
this pull request
Nov 19, 2024
* MODUAD-199 - pubsub permission changes. (#177) * pubsub permission changes. * pubsub permission changes. * Changes related to audit.pub-sub-handlers.log-record-event.post * pubsub permission changes. * pubsub permission changes. --------- Co-authored-by: Taras_Spashchenko <[email protected]> * "Update NEWS" NEWS.md * [maven-release-plugin] prepare release v2.10.1 * [maven-release-plugin] prepare for next development iteration --------- Co-authored-by: Taras_Spashchenko <[email protected]>
gurleenkaurbp
added a commit
that referenced
this pull request
Nov 19, 2024
* MODUAD-199 - pubsub permission changes. (#177) * pubsub permission changes. * pubsub permission changes. * Changes related to audit.pub-sub-handlers.log-record-event.post * pubsub permission changes. * pubsub permission changes. --------- Co-authored-by: Taras_Spashchenko <[email protected]> * "Update NEWS" NEWS.md * [maven-release-plugin] prepare release v2.10.1 * [maven-release-plugin] prepare for next development iteration --------- Co-authored-by: Taras_Spashchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.